Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mutability tests to match spec #1

Merged
merged 9 commits into from
May 16, 2022
Merged

Update mutability tests to match spec #1

merged 9 commits into from
May 16, 2022

Conversation

makew0rld
Copy link

@makew0rld makew0rld commented Apr 27, 2022

Adjusting to match this spec document.

I don't really know JS so I did the best I could 😄

@RangerMauve if you were able to DRY up this code it might be good, as there's a lot of repetition of things like uploading files and checking responses etc. Not a big deal though.

Copy link
Member

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far. Lets merge it in after we try running the tests.

Thanks!

Copy link
Member

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look perfect!

@RangerMauve RangerMauve merged commit 0b72465 into default May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants